Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferAttribute.setArray method chaining #13868

Merged
merged 4 commits into from
Apr 16, 2018

Conversation

takahirox
Copy link
Collaborator

Let's return this from BufferAttribute.setArray() and make it chain-able as other methods of BufferAttribute do.

@WestLangley
Copy link
Collaborator

Fine. How about returning this for InterleavedBuffer.setArray(), too?

And, of course, update the docs. :-)

Regarding this as a return value, @donmccurdy had a suggestion: see #13816 (comment).

@takahirox
Copy link
Collaborator Author

Agreed. I was just missing InterleavedBuffer.setArray() and documents. About method:this in the doc, let's consider in another PR.

@takahirox
Copy link
Collaborator Author

BTW, I wanna and am gonna enable "method chaining", not only for loaders or attributes, but also for other modules. For example I found bunch of methods in Object3D and BufferGeometry that should be chain-able but are not yet.

@WestLangley
Copy link
Collaborator

BTW, I wanna and am gonna enable "method chaining", not only for loaders...

Awesome! #13816 (comment)

@mrdoob mrdoob added this to the r92 milestone Apr 16, 2018
@mrdoob mrdoob merged commit eb35205 into mrdoob:dev Apr 16, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 16, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants