Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebGLBufferRenderer renderInstance bug #13948

Merged
merged 2 commits into from Apr 29, 2018
Merged

Fix WebGLBufferRenderer renderInstance bug #13948

merged 2 commits into from Apr 29, 2018

Conversation

06wj
Copy link
Contributor

@06wj 06wj commented Apr 28, 2018

When position is an InterleavedBufferAttribute, the start property does not take effect.

@WestLangley
Copy link
Collaborator

Nice find. This PR looks correct to me.

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 28, 2018

Yes, looks good. When this PR is merged, #13778 is not necessary anymore. Great! 😊

@mrdoob mrdoob added this to the r93 milestone Apr 29, 2018
@mrdoob mrdoob merged commit ec39df0 into mrdoob:dev Apr 29, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 29, 2018

Thanks!

@06wj 06wj deleted the patch0 branch April 29, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r93
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@06wj @WestLangley @Mugen87 @mrdoob