Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font: Remove unused divisions parameter from .generateShapes() #14270

Merged
merged 2 commits into from Jun 12, 2018

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 11, 2018

The fineness of the geometry based on a given shape is controlled via Shape.extractPoints(). This method is used in ShapeGeometry or ExtrudeGeometry.

@WestLangley
Copy link
Collaborator

You will have to track down the use of curveSegments, too.

For example, in TextBufferGeometry:

var shapes = font.generateShapes( text, parameters.size, parameters.curveSegments );

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 11, 2018

Thanks, I've actually missed that 👍

@WestLangley
Copy link
Collaborator

You will need to grep for curveSegments to find all the places where it needs to be removed.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 11, 2018

I don't think that's correct. curveSegments is used within ExtrudeGeometry in another context.

var shapePoints = shape.extractPoints( curveSegments );

@WestLangley
Copy link
Collaborator

I see. So in TextGeometry, setting parameters.curveSegments is still OK.

@mrdoob mrdoob added this to the r94 milestone Jun 12, 2018
@mrdoob mrdoob merged commit 292a2fd into mrdoob:dev Jun 12, 2018
@mrdoob
Copy link
Owner

mrdoob commented Jun 12, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants