Examples: Removed BufferSubdivisionModifier #14397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me! |
|
Thanks! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
BufferSubdivisionModifier.webgl_modifier_subdivisionnow useSubdivisionModifier.I'd like to remove this class since it uses
BufferGeometryin order to implement a modifier. I don't think this is a good approach sinceBufferGeometryis not intended for complex topological operations. It is focused on representing geometry data for rendering.Geometrywith its face abstraction performs better in context of modifiers. Depending on the use case, modifiers should use a half-edge data structure or something similar for a more sensible implementation (seeQuickHull).