Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera: Introduce .dispose() #16130

Closed
wants to merge 2 commits into from
Closed

Camera: Introduce .dispose() #16130

wants to merge 2 commits into from

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 2, 2019 •
edited by WestLangley

Solves #12464 (comment)

Analogous to Scene.dispose(). Allows more control about the disposal of internal cached objects.

@WestLangley
Copy link
Collaborator

Added some minor suggestions... :-)

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 2, 2019 •
edited

Updated the PR with your suggestions 👍

@WestLangley
Copy link
Collaborator

@mrdoob I am happy with the docs. I'll defer review of the source to you.

@ghost
Copy link

ghost commented Apr 18, 2019

Please add Camera.dispose to the TypeScript definitions.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 18, 2019

@errorx666 Okay, I'm doing this if @mrdoob approves the change in general.

@Mugen87 Mugen87 closed this Jun 19, 2019
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2022
Open
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WestLangley WestLangley WestLangley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mugen87 @WestLangley