Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Convert textures to sRGB encoding #16148

Merged
merged 2 commits into from Apr 16, 2019
Merged

Editor: Convert textures to sRGB encoding #16148

merged 2 commits into from Apr 16, 2019

Conversation

Temdog007
Copy link
Contributor

Fixes #15903

Based @mrdoob's comment

@Temdog007
Copy link
Contributor Author

For testing: https://raw.githack.com/Temdog007/three.js/editor/ColorFix/editor/index.html

mrdoob
mrdoob reviewed Apr 7, 2019
View reviewed changes
editor/js/libs/ui.three.js Outdated Show resolved Hide resolved
@mrdoob mrdoob added this to the r104 milestone Apr 7, 2019
@Temdog007
Copy link
Contributor Author

Temdog007 commented Apr 7, 2019 •
edited

##### Concerns

Using a map with THREE.sRGBEncoding causes this warning to appear:

warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them

I'm assuming that issue will be a separate PR if this one gets merged.

@Temdog007 Temdog007 mentioned this pull request Apr 14, 2019
Closed
@mrdoob
Copy link
Owner

mrdoob commented Apr 16, 2019

Looking good!

@mrdoob mrdoob merged commit c4893ef into mrdoob:dev Apr 16, 2019
@mrdoob
Copy link
Owner

mrdoob commented Apr 16, 2019

Thanks!

@Temdog007 Temdog007 deleted the editor/ColorFix branch May 5, 2019 00:26
@Mugen87 Mugen87 mentioned this pull request Aug 28, 2020
Merged
This was referenced Oct 23, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdoob mrdoob mrdoob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r104
Development

Successfully merging this pull request may close these issues.

Editor: all colors/textures washed out in r102
2 participants
@Temdog007 @mrdoob