Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransformControls: Added scaleSnap. #18146

Merged
merged 1 commit into from Dec 18, 2019
Merged

TransformControls: Added scaleSnap. #18146

merged 1 commit into from Dec 18, 2019

Conversation

arodic
Copy link
Sponsor Contributor

@arodic arodic commented Dec 13, 2019

Added scaleSnap to TransformControls. Fixes #14902

@Mugen87 Mugen87 added this to the r112 milestone Dec 13, 2019
@arodic arodic mentioned this pull request Dec 13, 2019
Closed
@arodic
Copy link
Sponsor Contributor Author

arodic commented Dec 13, 2019

Live demo: https://raw.githack.com/arodic/three.js/feature/TransformControlls-scaleSnap/examples/misc_controls_transform.html

Press "R" for scale, then hold "ctrl" for snapping.

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 13, 2019

Cool 👍

@mrdoob
Copy link
Owner

mrdoob commented Dec 13, 2019 •
edited

On MacOS Ctrl+Click shows the context menu. Would Shift+Click work?

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 18, 2019

On MacOS Ctrl+Click shows the context menu. Would Shift+Click work?

I'll make a PR with the fix.

@Mugen87 Mugen87 merged commit 1ac9c9b into mrdoob:dev Dec 18, 2019
@Mugen87 Mugen87 changed the title Added scaleSnap to TransformControls. Fixes #14902 TransformControls: Added scaleSnap. Dec 18, 2019
@Mugen87 Mugen87 mentioned this pull request Dec 18, 2019
Merged
@mrdoob
Copy link
Owner

mrdoob commented Dec 18, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r112
Development

Successfully merging this pull request may close these issues.

Scaling snap for the Transform Controls
3 participants
@arodic @Mugen87 @mrdoob