New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: Add missing types: is*** #18259

Merged

Mugen87 merged 5 commits into mrdoob:dev from yomotsu:feature/add-type-isXXX

Dec 30, 2019

Contributor

yomotsu commented Dec 28, 2019

isXXX is missing in d.ts.
This PR is to fill them.

yomotsu added 2 commits

December 29, 2019 02:45


          add type is*** to d.ts

d49f86f


          revert Matrix3 and 4, because of wrong extending in d.ts

2253c86

Collaborator

Mugen87 commented Dec 28, 2019

Um, can we mark all is* properties as read-only?

Related #18217 .

Mugen87 changed the title [d.ts] Add missing types: is*** TS: Add missing types: is***

Contributor Author

yomotsu commented Dec 29, 2019 •

edited

Thanks for the suggestion.
Regarding it, Which one is preferable?

readonly isBox3: boolean
isBox3: true

Seems some are already isXXX: true like
https://github.com/mrdoob/three.js/blob/dev/src/math/Vector3.d.ts#L30

But we can respect the actual value in .js file (which is true) to set boolean as readonly as you suggested.

or maybe both: readonly isBox3: true

Collaborator

donmccurdy commented Dec 29, 2019

I'd suggest both: readonly isBox3: true 👍


          make is* readonly in d.ts

a51e4aa

Contributor Author

yomotsu commented Dec 29, 2019

Done it 👍

Mugen87 added this to the r113 milestone

Mugen87 approved these changes

View reviewed changes

Mugen87 added 2 commits

December 29, 2019 13:29


          Merge branch 'dev' into feature/add-type-isXXX

db73e26


          Update Node.d.ts

donmccurdy approved these changes

View reviewed changes

Mugen87 merged commit 3ba0553 into mrdoob:dev

Owner

mrdoob commented Dec 30, 2019

Thanks!

yomotsu deleted the feature/add-type-isXXX branch

December 30, 2019 16:05

EliasHasle added a commit to EliasHasle/three.js that referenced this pull request


          Added readonly is*** fields in TS declaration files

9c002ac

See mrdoob#18259

EliasHasle added a commit to EliasHasle/three.js that referenced this pull request


          Added readonly is*** fields in TS declaration files

2a938de

See mrdoob#18259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment