Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderer: Add mipmap & compressed texture handling to .copyTextureToTexture(). #18681

Merged
merged 11 commits into from
Apr 3, 2020
Merged

WebGLRenderer: Add mipmap & compressed texture handling to .copyTextureToTexture(). #18681

merged 11 commits into from
Apr 3, 2020

Conversation

frankolivier
Copy link
Contributor

@frankolivier frankolivier commented Feb 20, 2020 •
edited

Fixes #18736
Fixes #18821

@frankolivier frankolivier changed the title Make copyTextureToTexture generate mipmaps Add mipmap handling to copyTextureToTexture Feb 20, 2020
Update WebGLRenderer.js
5685eba 
Added check for mipmap level 0
@frankolivier
Copy link
Contributor Author

Added a check for mipmap level 0; added 0 as the default level for this function

IMO the check is safe - if the developer wanted to manually handle mipmaps ( by setting dstTexture.generateMipmaps = false ) _gl.generateMipmap() should not be called in the added code.

Update WebGLRenderer.js
9bc1542 
Changed from default parameter to  level = level || 0
@mrdoob mrdoob added this to the r114 milestone Feb 25, 2020
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 25, 2020

Can you please remove build/three.module.js from your PR?

@Mugen87 Mugen87 changed the title Add mipmap handling to copyTextureToTexture WebGLRenderer: Add mipmap handling to .copyTextureToTexture(). Feb 25, 2020
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 25, 2020

Um, now you have completely removed build/three.module.js. The idea was to just undo your changes to build/three.module.js.

@mrdoob
Copy link
Owner

mrdoob commented Feb 25, 2020

Fixes #14423

Hmm, do you mind explaining how this fixes #14423?

@mrdoob mrdoob modified the milestones: r114, r115 Feb 25, 2020
@frankolivier
Copy link
Contributor Author

Ah, my bad - it would not actually fix #14423.

I've filed a new issue #18736 for the actual issue I was trying to fix for my project.

@frankolivier frankolivier changed the title WebGLRenderer: Add mipmap handling to .copyTextureToTexture(). WebGLRenderer: Add mipmap & compressed texture handling to .copyTextureToTexture(). Mar 11, 2020
@mrdoob mrdoob modified the milestones: r115, r116 Mar 25, 2020
@mrdoob mrdoob merged commit 148c101 into mrdoob:dev Apr 3, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 3, 2020

Thanks!

@Mugen87 Mugen87 mentioned this pull request Apr 3, 2020
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdoob mrdoob mrdoob left review comments

@donmccurdy donmccurdy donmccurdy left review comments

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r116
4 participants
@frankolivier @Mugen87 @mrdoob @donmccurdy