Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CubeCamera: Add support for THREE.Layers. #18760

Merged
merged 1 commit into from May 20, 2020
Merged

CubeCamera: Add support for THREE.Layers. #18760

merged 1 commit into from May 20, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 27, 2020

Fixed #14804.

I've noticed this when playing around with THREE.Layers and THREE.Raycaster. I think it's more correct if the sub-cameras use the same layer object otherwise layer configuration won't work.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 27, 2020

@munrocket Any ideas why webgl_kinect tends to fail in the regression tests? I'm sure it's unrelated to this PR since the example does not use a cube camera.

@munrocket
Copy link
Contributor

@Mugen87 tried to bring determinism in video tag, but my the only solution was to increase number of attempts. We added css3d_youtube in ignore list for same reason.

I tried also beginFrame API but it fails in Three.js repo #18732.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 27, 2020

In this case, I would add webgl_kinect to the ignore list, too.

@munrocket
Copy link
Contributor

This picture reminds me Picard from Star Trek :D

@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 19, 2020

@mrdoob This PR probably got lost. Are you okay with this change? Or could this be implemented in the renderer somehow (by testing for CubeCamera)? The current change encapsulates this logic in CubeCamera which is probably more straightforward.

@mrdoob
Copy link
Owner

mrdoob commented May 20, 2020

It sure got lost!

@mrdoob mrdoob added this to the r117 milestone May 20, 2020
@mrdoob mrdoob merged commit 3e37e65 into mrdoob:dev May 20, 2020
@mrdoob
Copy link
Owner

mrdoob commented May 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CubeCamera does not support layers
3 participants