-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Make examples searchable by tags. #18779
Conversation
This approach seems more appropriate to me than #18773 👍 |
I want to suggest to add:
There are probably other tags. |
Pretty sure they are, just recently I was searching for something again and had to change the search terms in order to find that... but cant remember what was it. Just added your suggestions. |
Don’t you think that
Or this is not important? |
@munrocket Idk, I kind of thought an array is more telling to whoever stumbles upon it that you could add items to it. And you know this is not a tight loop or anything, so who cares about performance? Typical user will type what, 5 characters per second? This is how much that code runs. |
btw, the regexp search results are puzzling. consider https://threejs.org/examples/?q=[^\f] for example: |
Also can't find examples with |
Closing in favor of #19245. |
Thanks! |
So, the reason it took me so long to merge this was that I felt like the code was "too smart" and I needed to play with it and see if I could find a dumber/simpler approach. I just played a little bit with it and this is what I came up with: e78da33 If you guys have any suggestions on how I should phrase that kind of feedback, I'm all ears! 👂 |
@mrdoob Im in favor of you just committing your version and then thinking how to phrase feedback later over a glass of wine when the actual problem is fixed. |
That's exactly what I did 😁 |
Basically what commit says - as per #18700 (comment)
@munrocket I thought about adding the tags from #18773 here, but a bunch of entries like
make me think your autogeneration script needs some finetuning, no?