Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Make examples searchable by tags. #18779

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Conversation

makc
Copy link
Contributor

@makc makc commented Feb 29, 2020

Basically what commit says - as per #18700 (comment)

@munrocket I thought about adding the tags from #18773 here, but a bunch of entries like

		"webxr_ar_paint",
		{ 'file': 'webxr_ar_paint', 'tags': 'Tiled forward lightingCreated by wizgrav.' },
		"webxr_vr_ballshooter",
		{ 'file': 'webxr_vr_ballshooter', 'tags': 'Tiled forward lightingCreated by wizgrav.' },
		"webxr_vr_cubes",
		{ 'file': 'webxr_vr_cubes', 'tags': 'Tiled forward lightingCreated by wizgrav.' },
		"webxr_vr_dragging",
		{ 'file': 'webxr_vr_dragging', 'tags': 'Tiled forward lightingCreated by wizgrav.' },

make me think your autogeneration script needs some finetuning, no?

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 29, 2020

@Mugen87 Mugen87 changed the title fixes #18700 as suggested by @mrdoob Examples: Make examples searchable by tags. Feb 29, 2020
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 29, 2020

This approach seems more appropriate to me than #18773 👍

@munrocket
Copy link
Contributor

munrocket commented Mar 3, 2020

I want to suggest to add:

"webgl_shadowmap_csm": [ "cascade" ],
"webgl_materials_translucency": ["subsurface", "scattering"],
"webgl_simple_gi": ["global", "illumination"],
"webgl_shadowmap_pcss": ["soft"],
"webgl_fire": ["smoke"],
"webgl_clipping_intersection": ["csg", "solid"]

There are probably other tags.

@makc
Copy link
Contributor Author

makc commented Mar 3, 2020

There are probably other tags.

Pretty sure they are, just recently I was searching for something again and had to change the search terms in order to find that... but cant remember what was it.

Just added your suggestions.

@munrocket
Copy link
Contributor

Don’t you think that .join( ‘ ‘ ) operator is waste of time and you can store tags already joined?

"webgl_simple_gi": "global illumination, tag2, tag3" 

Or this is not important?

@makc
Copy link
Contributor Author

makc commented Mar 3, 2020

@munrocket Idk, I kind of thought an array is more telling to whoever stumbles upon it that you could add items to it. And you know this is not a tight loop or anything, so who cares about performance? Typical user will type what, 5 characters per second? This is how much that code runs.

@makc
Copy link
Contributor Author

makc commented Mar 7, 2020

btw, the regexp search results are puzzling. consider https://threejs.org/examples/?q=[^\f] for example:
Screen Shot 2020-03-07 at 12 32 06
technically correct, but... wtf

@munrocket
Copy link
Contributor

Also can't find examples with renderTargets.

@munrocket
Copy link
Contributor

Closing in favor of #19245.
Since this relatively simple and useful PR was not merged in one month.

@munrocket munrocket closed this Apr 28, 2020
@munrocket munrocket reopened this Apr 29, 2020
@mrdoob mrdoob added this to the r116 milestone Apr 30, 2020
@mrdoob mrdoob merged commit c3f58ff into mrdoob:dev Apr 30, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 30, 2020

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Apr 30, 2020

So, the reason it took me so long to merge this was that I felt like the code was "too smart" and I needed to play with it and see if I could find a dumber/simpler approach.

I just played a little bit with it and this is what I came up with: e78da33

If you guys have any suggestions on how I should phrase that kind of feedback, I'm all ears! 👂

@makc
Copy link
Contributor Author

makc commented Apr 30, 2020

@mrdoob Im in favor of you just committing your version and then thinking how to phrase feedback later over a glass of wine when the actual problem is fixed.

@mrdoob
Copy link
Owner

mrdoob commented Apr 30, 2020

That's exactly what I did 😁

@makc makc deleted the better-search-2 branch November 27, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants