LightProbe: Add support for serialization/deserialization. #18966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Mar 24, 2020
| @@ -26,7 +28,6 @@ LightProbe.prototype = Object.assign( Object.create( Light.prototype ), { | |||
| Light.prototype.copy.call( this, source ); | |||
|
|
|||
| this.sh.copy( source.sh ); | |||
| this.intensity = source.intensity; | |||
There was a problem hiding this comment.
intensity is already copied in Light.copy().
There was a problem hiding this comment.
As a FYI, seems like @WestLangley is thinking of removing that inheritance. #18371 (comment)
There was a problem hiding this comment.
Thanks for sharing, good to know! Should I keep the code as it is now?
There was a problem hiding this comment.
I think so -- for now.
donmccurdy
reviewed
Mar 24, 2020
I forgot I did that. 👴 |
mrdoob
reviewed
Mar 25, 2020
| @@ -36,7 +46,7 @@ LightProbe.prototype = Object.assign( Object.create( Light.prototype ), { | |||
|
|
|||
| var data = Light.prototype.toJSON.call( this, meta ); | |||
|
|
|||
| // data.sh = this.sh.toArray(); // todo | |||
| data.object.sh = this.sh.toArray(); | |||
There was a problem hiding this comment.
Yes, check out Light.toJSON():
Line 44 in df2b31f
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 21e3eab, serialization/deserialization is now easy to add.