LineGeometry, LineSegmentsGeometry: Fix Bugs #18974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Mar 25, 2020
WestLangley
reviewed
Mar 25, 2020
|
Hey,guys ,this is my second contribution for three.js, and I'm still excited. This is a great thing,I like it . I will continue to contribute to three.js. 😄 |
|
In this case, it's good if you know how the generate the module versions: Go to the root directory and then execute |
…ry.d.ts in the jsm directory.
WestLangley
changed the title
|
@mrdoob This PR is good to go 🚀 . |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug using line2. Linesegmentsgeometry.fromlinesegments and linegeometry.fromline, when setting position, do not get position in the case of buffergeometry.So I fixed it and tried to make a pr.:smile: