Texture: Add WorldMapping to use world coordinates for texturing (#18992) #19010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding a live link. I'm in the process of adding my build from this PR to my application to see if it actually solves my problem 😉. There seems like there might be an issue so hold off on merging for now. Comments are welcome though. |
|
Okay, after some fixes, there are no remaining issues with my app. This is mergable AFAIK 😄 |
|
see #18992 (comment) |
|
see #18992 (comment), in response to previous comment |
2 tasks
|
I agree that this is application specific and doesn't belong in core -- I think node materials or ShaderMaterials serve this use case well. |
|
Okay, let's close this and finalize discussion in the issue. |
|
Removed temporary live link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
THREE.WorldMapping, an alternative toTHREE.UVMapping.WorldMappingworks by using two (user defined) axes of the vertex's world coordinates as the UV coordinates for texture mapping. It is configurable via the API:This is crucial for applying "seamless" textures to grids of non-square objects without manually setting the UVs of each one. As a result,
InstancedMeshis supported.The changes don't break any of the examples I tried running.
A working example is available:
webgl_materials_texture_worldmappingPlease see #18992 for more details.
Warning: This is my first PR on this repository and the biggest PR I have ever written for any repository. It may break things. Please merge with caution. Suggestions for changes/fixes welcome.