Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: make math expression in language. #19055

Merged
merged 2 commits into from Apr 8, 2020
Merged

Conversation

linbingquan
Copy link
Contributor

@mrdoob
Copy link
Owner

mrdoob commented Apr 7, 2020

Suggested wording improvement:
#19054 (comment)

@mrdoob mrdoob added this to the r116 milestone Apr 7, 2020
@linbingquan
Copy link
Contributor Author

Suggested wording improvement:
#19054 (comment)

Thanks.

@WestLangley
Copy link
Collaborator

You didn't type what I suggested.

@linbingquan
Copy link
Contributor Author

You didn't type what I suggested.

I am sorry, @WestLangley you mean these sentences are totally replaced by Sets each component of this vector to a pseudo-random value between 0 and 1, excluding 1., It that right?

Sets the x and y components of this vector to a random value [0-1].

Sets the x, y and z components of this vector to a random value [0-1].

Sets the x, y, z and w components of this vector to a random value [0-1].

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 7, 2020

Simply use #19054 (comment).

@WestLangley
Copy link
Collaborator

@WestLangley you mean these sentences are totally replaced...?

@linbingquan Yes. All files can use the same sentence.

@linbingquan
Copy link
Contributor Author

Thanks, I have done.

@mrdoob mrdoob merged commit 6230d4c into mrdoob:dev Apr 8, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 8, 2020

Thanks!

@linbingquan linbingquan deleted the dev-doc branch May 23, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants