Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Fix compression artifacts of normal map. #19249

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 28, 2020

Fixed #8235.

I've recreated the normal map and then converted to PNG. The result is noticeably better.

@WestLangley
Copy link
Collaborator

Thanks for working on this! :-)

I'm seeing differences, but I am not seeing "better". But maybe I am missing something...

I've recreated the normal map and then converted to PNG.

What, exactly, did you do? I assume you did not create a JPG first and then convert...

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 28, 2020

I've exported from MeshMapper to (lossless) TIFF and then converted to (lossless) PNG via Photoshop.

I'm seeing differences, but I am not seeing "better".

It's definitely better ;). I can't see the (DCT) typical blocky artifacts anymore.

@mrdoob mrdoob added this to the r116 milestone Apr 29, 2020
@mrdoob mrdoob merged commit 550d0ca into mrdoob:dev Apr 29, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 29, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ninja Head model has overly compressed normal map - lots of artifacts
3 participants