Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Clean up webgl_loader_mmd_audio. #19259

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Examples: Clean up webgl_loader_mmd_audio. #19259

merged 2 commits into from
Apr 30, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 30, 2020

Fixed #19258.

webgl_loader_mmd_audio needs the same approach like other WebAudio demos.

Besides, a deprecated line in MMDAnimationHelper was removed which had no effect anymore. Audio.startTime has been removed with R110. Even without the line, Miku seems to start singing at the right point^^.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 30, 2020

@tag3r
Copy link

tag3r commented Apr 30, 2020

It still no audio in Safari (Mac) and Ios >13 (All Browsers)

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 30, 2020

Um, it solved the issue for me tested on macOS 10.15.4 and Chrome 81.0.4044.129.

Can you please check if the Web Audio demos work for you? E.g.:

https://threejs.org/examples/webaudio_timing
https://threejs.org/examples/webaudio_visualizer

@tag3r
Copy link

tag3r commented Apr 30, 2020

Um, it solved the issue for me tested on macOS 10.15.4 and Chrome 81.0.4044.129.

Can you please check if the Web Audio demos work for you? E.g.:

https://threejs.org/examples/webaudio_timing
https://threejs.org/examples/webaudio_visualizer

Yes on Mac + Chrome all ok but on Mac + Safari no audio.
Two examples that you linked both work fine on Mac + Safari but no audio on Ios >13 (All browsers) in lastone. First 'webaudio_timing' works...
(And i don't know why =( )

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 30, 2020

@tag3r
Copy link

tag3r commented Apr 30, 2020

Yes, but why https://threejs.org/examples/webaudio_timing working??

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 30, 2020

It does not use audio tags but audio buffers (loaded via AudioLoader).

@mrdoob mrdoob added this to the r116 milestone Apr 30, 2020
@mrdoob mrdoob merged commit 5c6bbff into mrdoob:dev Apr 30, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 30, 2020

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Apr 30, 2020

I'll reopen #19258 so we can continue the conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mmd loader not play audio in Safari (Mac) and all Browsers (Ios >13)
3 participants