Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Updated Sidebar.Project.js #19434

Merged
merged 2 commits into from May 25, 2020
Merged

Editor: Updated Sidebar.Project.js #19434

merged 2 commits into from May 25, 2020

Conversation

linbingquan
Copy link
Contributor

Fixed bug for toggled physicallyCorrectLights button, renderer changed without toneMappingExposure value.

@Mugen87
Copy link
Collaborator

Mugen87 commented May 23, 2020

Um, changing the tonemapping exposure does not require to rebuild the renderer.

Can you please explain in more detail how the bug occurs.

@linbingquan
Copy link
Contributor Author

Um, changing the tonemapping exposure does not require to rebuild the renderer.

Can you please explain in more detail how the bug occurs.

I am not good at English, I speek Chinglish, I hope I can explain clear.

  1. Set Exposure 0.1 value
  2. Toggle Physically corrent lights checkbox.
  3. The renderer is not Exposure 0.1 value result.

image

@Mugen87
Copy link
Collaborator

Mugen87 commented May 24, 2020

Okay, that helps! I understand now the issue. In this case, we also have to do the same for toneMappingWhitePoint. Can you please update the PR?

@mrdoob mrdoob added this to the r117 milestone May 25, 2020
@mrdoob mrdoob merged commit 15f0354 into mrdoob:dev May 25, 2020
@mrdoob
Copy link
Owner

mrdoob commented May 25, 2020

Thanks!

@linbingquan linbingquan deleted the dev-editor branch May 28, 2020 00:28
@Mugen87 Mugen87 mentioned this pull request May 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r117
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@linbingquan @Mugen87 @mrdoob