Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated: common.glsl.js #19481

Merged
merged 1 commit into from May 28, 2020
Merged

Updated: common.glsl.js #19481

merged 1 commit into from May 28, 2020

Conversation

linbingquan
Copy link
Contributor

@linbingquan linbingquan commented May 28, 2020 •
edited by Mugen87

Fixed #19472

@WestLangley WestLangley added this to the r118 milestone May 28, 2020
Mugen87
Mugen87 approved these changes May 28, 2020
View reviewed changes
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find a usage of LOG2 in the core or examples so the removal seems save.

@mrdoob mrdoob merged commit d6a6d76 into mrdoob:dev May 28, 2020
@mrdoob
Copy link
Owner

mrdoob commented May 28, 2020

Thanks!

@linbingquan linbingquan deleted the dev-shader branch May 30, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r118
Development

Successfully merging this pull request may close these issues.

Question: Why not use same floating point number in common.glsl.js
4 participants
@linbingquan @mrdoob @Mugen87 @WestLangley