Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLSL: Add glsl tag for highlight plugin. #19532

Merged
merged 1 commit into from
Jun 3, 2020
Merged

GLSL: Add glsl tag for highlight plugin. #19532

merged 1 commit into from
Jun 3, 2020

Conversation

linbingquan
Copy link
Contributor

No description provided.

@linbingquan
Copy link
Contributor Author

I don't know how to pass those test case in npm run test-e2e

two fail test case

ERROR! Diff wrong in 0.309 of pixels in file: webgl_sprites
ERROR! Diff wrong in 0.309 of pixels in file: webgl_lensflares

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 3, 2020

two fail test case

Don't worry about it. There is an ongoing CI-issue with examples that use Math.random().

@mrdoob mrdoob added this to the r118 milestone Jun 3, 2020
@mrdoob mrdoob merged commit 7757183 into mrdoob:dev Jun 3, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jun 3, 2020

Thanks!

@linbingquan linbingquan deleted the dev-glsl branch July 29, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r118
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@linbingquan @Mugen87 @mrdoob