Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests: NothingsIsExportedYet means nothing is exported #19559

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Unit Tests: NothingsIsExportedYet means nothing is exported #19559

merged 1 commit into from
Jun 4, 2020

Conversation

gero3
Copy link
Contributor

@gero3 gero3 commented Jun 4, 2020

When running the unittests, you get a warning about the import of non-existent exports.

To Reproduce:

  • run 'npm run test-unit'

Issue

  • The '(!) Import of non-existent exports' warning gets sent because the 'NothingsIsExportedYet' export doesn't exist.
    image

Solution

  • When nothing needs to be imported , then import nothing.

@mrdoob mrdoob added this to the r118 milestone Jun 4, 2020
@mrdoob mrdoob merged commit e3c595c into mrdoob:dev Jun 4, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jun 4, 2020

Thanks!

@mrdoob mrdoob changed the title NothingsIsExportedYet means nothing is exported Unit Tests: NothingsIsExportedYet means nothing is exported Jun 4, 2020
@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 5, 2020

Thanks for fixing these annoying messages^^.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r118
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gero3 @mrdoob @Mugen87