Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PointerLockControls: add min/max polar angle #19580

Merged
merged 1 commit into from
Jun 7, 2020
Merged

PointerLockControls: add min/max polar angle #19580

merged 1 commit into from
Jun 7, 2020

Conversation

WestLangley
Copy link
Collaborator

... in keeping with the terminology of OrbitControls.

The nomenclature could be changed to something like min/maxCameraPitch, min/maxElevationAngle, ...

@WestLangley WestLangley added this to the r118 milestone Jun 7, 2020
@mrdoob mrdoob merged commit 512162a into mrdoob:dev Jun 7, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jun 7, 2020

Thanks!

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 7, 2020 •
edited

@WestLangley Please also update examples/js/controls/PointerLockControls.js or the changes to the module version will be quickly undone. Updating the TS file would be good, too 👍 .

@WestLangley
Copy link
Collaborator Author

Please also update examples/js

Oops..

@WestLangley WestLangley mentioned this pull request Jun 7, 2020
Merged
@WestLangley WestLangley deleted the dev_pointer_lock branch June 8, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r118
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WestLangley @mrdoob @Mugen87