Examples: Clean up. #19625
Merged
Examples: Clean up. #19625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Jun 11, 2020
| @@ -169,7 +169,7 @@ | |||
| renderer.setSize( window.innerWidth, window.innerHeight ); | |||
| container.appendChild( renderer.domElement ); | |||
|
|
|||
| if ( renderer.extensions.get( 'ANGLE_instanced_arrays' ) === null ) { | |||
| if ( renderer.capabilities.isWebGL2 === false && renderer.extensions.get( 'ANGLE_instanced_arrays' ) === null ) { | |||
There was a problem hiding this comment.
Yes, I think you're right. Better to keep them, I was being too lazy yesterday 😅
1 task
|
Thanks! |
|
You have to re-make screen shots. Otherwise, unrelated PRs by others fail CI tests. CI is becoming a pain... |
|
I've actually updated the screenshots in the PR. The last broken example that currently makes trouble is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain extension tests like in webgl_buffergeometry_instancing have to be changed since they don't work with WebGL 2 (the extensions exists by default).
The PR also fixes remaining ACES Filmic tone mapping settings and the shader compilation error in
BlurNode.