WebGLProgram: Simplify encodings checks. #19637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working at #19634, I've realized that the encoding checks in
WebGLProgram
can be improved.Since
parameters.outputEncoding
is always set,encodings_pars_fragment
can always be included. Besides, sinceparameters.mapEncoding
always has a value, it's more correct to testparameters.map
(which can be true or false depending on whether a diffuse texture is used or not). This is also true for the other texture types.