ShadowMaterial: Fix handling shadow map offset #19681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowMaterial vertex shader needs to include common and have access to the view matrix to be able to apply shadow normal offset.
Mugen87
approved these changes
Jun 17, 2020
mrdoob
reviewed
Jun 17, 2020
| @@ -1786,6 +1786,7 @@ function WebGLRenderer( parameters ) { | |||
| material.isMeshBasicMaterial || | |||
| material.isMeshStandardMaterial || | |||
| material.isShaderMaterial || | |||
| material.isShadowMaterial || | |||
There was a problem hiding this comment.
Ah, I looked into this and I figured out the <common> bit, but not this bit 🙏
|
Thanks! |
|
No problem! Glad to see normal offset support merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShadowMaterial vertex shader needs to include common and have access to the view matrix to be able to apply shadow normal offset. This fixes issue introduced in PR #18915.