Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderer: Accept null when using setAnimationLoop(). #19695

Merged
merged 2 commits into from
Jun 20, 2020
Merged

WebGLRenderer: Accept null when using setAnimationLoop(). #19695

merged 2 commits into from
Jun 20, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 20, 2020 •
edited

Fixed #19689.

WebGLAnimation also makes now use of cancelAnimationFrame().

BTW: Was there a reason for not using cancelAnimationFrame() when implementing WebGLAnimation?

@mrdoob
Copy link
Owner

mrdoob commented Jun 20, 2020

BTW: Was there a reason for not using cancelAnimationFrame() when implementing WebGLAnimation?

I don't remember. I was probably going step by step and forgot to finish it?

Anyway, lets see if nothing breaks 🤞

@mrdoob mrdoob added this to the r118 milestone Jun 20, 2020
@mrdoob mrdoob merged commit fd784a6 into mrdoob:dev Jun 20, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jun 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r118
Development

Successfully merging this pull request may close these issues.

setAnimationLoop(null) does not call animation.stop()
2 participants
@Mugen87 @mrdoob