Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CatmullRomCurve3: Ensure zero is valid argument for tension. #19762

Merged
merged 1 commit into from Jun 30, 2020
Merged

CatmullRomCurve3: Ensure zero is valid argument for tension. #19762

merged 1 commit into from Jun 30, 2020

Conversation

dskeithbuck
Copy link
Contributor

Fix Issue #19757

@Mugen87 Mugen87 changed the title Handle tension=0 CatmullRomCurve3: Ensure zero is valid argument for tension. Jun 30, 2020
@WestLangley WestLangley added this to the r119 milestone Jun 30, 2020
@dskeithbuck
Copy link
Contributor Author

This is the first time I've done a pull-request on a public project. Please let me know if there's anything further I need to do as I don't totally understand the process. Thank you!

@mrdoob
Copy link
Owner

mrdoob commented Jun 30, 2020

Perfect PR 👌

@mrdoob mrdoob merged commit 370282e into mrdoob:dev Jun 30, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jun 30, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r119
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dskeithbuck @mrdoob @Mugen87 @WestLangley