Editor: Don't overwrite editor camera in Viewport. #19826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a subtle bug in
Viewport
. When the viewport camera is changed, theviewportCameraChanged
handler assigns the new camera tocamera
and thus overwrites the references to the editor's default perspective camera.This actually breaks the resizing logic which is now encapsulated in
updateAspectRatio()
. To avoid this and for clarity reasons, it's best when thecamera
variable inViewport
always points toeditor.camera
.