Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: added toggle for previews #19881

Merged
merged 1 commit into from Jul 20, 2020
Merged

Examples: added toggle for previews #19881

merged 1 commit into from Jul 20, 2020

Conversation

ajflores1604
Copy link
Contributor

@ajflores1604 ajflores1604 commented Jul 20, 2020 •
edited by mrdoob

Added a section to toggle preview images on the examples page for easier navigation and scrolling
https://ajflores-public.netlify.app/70202541/threejs/examples/index.html

@ajflores1604 ajflores1604 changed the title added toggle for example previews Examples: added toggle for previews Jul 20, 2020
@mrdoob mrdoob added this to the r119 milestone Jul 20, 2020
@mrdoob mrdoob merged commit 1539ed6 into mrdoob:dev Jul 20, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jul 20, 2020

Thanks!

@marcofugaro
Copy link
Contributor

Nice! I like this solution.

Make sure to add cursor: pointer; to the selectable toggle buttons (#panel #toggles *:not(.selected)).

@mrdoob
Copy link
Owner

mrdoob commented Jul 20, 2020 •
edited

Did some code and design refactoring: f60dc5b

Screen Shot 2020-07-21 at 10 17 30 AM

@mrdoob mrdoob mentioned this pull request Jul 20, 2020
Merged
@mrdoob
Copy link
Owner

mrdoob commented Jul 20, 2020

Even simpler implementation (thanks to Bojack on discord): c30ab07

@mrdoob
Copy link
Owner

mrdoob commented Jul 20, 2020

More simplifications: e5a6f37 d9dc3d0

@mrdoob
Copy link
Owner

mrdoob commented Jul 21, 2020 •
edited

Latest iteration:

Screen Shot 2020-07-21 at 10 17 30 AM

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 21, 2020

Looks great now! 👍

@mrdoob mrdoob mentioned this pull request Jul 22, 2020
Closed
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 25, 2020

During testing on dev, I've encounter a small style issue.

image

When webgl is not the first heading (because of filtering), the top border of subsequent headings goes through the toggle icon.

This was referenced Jul 25, 2020
Closed
Closed
@gsimone gsimone mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r119
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajflores1604 @mrdoob @marcofugaro @Mugen87