Scene: Remove dispose(). #19972
Merged
Scene: Remove dispose(). #19972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scene.dispose()was introduced with #15523 in order to clear cached objects inWebGLRenderListsandWebGLRenderStates. At that time, it was necessary since the caches were plain objects.Later, #17242 turned these objects into weak maps. I've realized now that this change made explicit disposals of scenes superfluous since the entries in the maps are automatically removed if a scene object is not used anymore. If the entire
rendereris disposed, the maps are cleared anyway.In contrast to other engine entities like geometries or textures, render lists and states do not have a GPU pendant so deallocating data from the GPU is not necessary.
This PR would also make #19645 not necessary anymore.