Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColladaExporter: Fix runtime error when processing ImageBitmap. #20049

Merged
merged 1 commit into from Aug 17, 2020
Merged

ColladaExporter: Fix runtime error when processing ImageBitmap. #20049

merged 1 commit into from Aug 17, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 11, 2020 •
edited

This bug was reported in the forum (via PM).

@Mugen87 Mugen87 added this to the r120 milestone Aug 15, 2020
@mrdoob
Copy link
Owner

mrdoob commented Aug 16, 2020

Hmm... Why is the code using image.naturalWidth and image.naturalHeight?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Aug 16, 2020

Hmm... Why is the code using image.naturalWidth and image.naturalHeight?

@gkjohnson Can you help here? 😇

@gkjohnson
Copy link
Collaborator

Mm I don't believe there's a good reason to use naturalWidth over width -- I think the function could just be changed to use width and height to simplify things.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Aug 17, 2020

Okay, updated to PR to just use width and height.

@mrdoob mrdoob merged commit 0ff40ec into mrdoob:dev Aug 17, 2020
@mrdoob
Copy link
Owner

mrdoob commented Aug 17, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r120
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mugen87 @mrdoob @gkjohnson