-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera: Properly update world matrix prior to use #20224
Conversation
@Mugen87 I think this completes the remaining use cases. :-) |
@WestLangley What do you think about introducing default parameters to updateWorldMatrix: function ( updateParents = true, updateChildren = false ) { This seems to be a proper default for a world matrix update routine. |
The method has implied default values of If you would like default values specified explicitly, I would suggest: updateWorldMatrix: function ( updateParents = false, updateChildren = false ) { I think @donmccurdy would be particularly happy with that decision. :-) This makes it clear that it is the user's responsibility to traverse the tree based on the user's use case. |
that sounds like the way to go IMO |
Again, let's ensure the method returns the correct answer as a first step. We can improve it later. |
This PR is a follow-up to #19969. |
Thanks! |
No description provided.