Examples: Clean up. #20246
Merged
Examples: Clean up. #20246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Sep 2, 2020
|
|
||
| let bufferPointer = 0; | ||
| let slashesCount = 0; | ||
| let word = ''; | ||
| let currentByte = 0; | ||
| for ( let code, currentByte = 0; currentByte < length; currentByte ++ ) { | ||
| for ( let code; currentByte < length; currentByte ++ ) { |
There was a problem hiding this comment.
@kaisalmen I believe this was a bug. You have declared currentByte two times. Hence, the outer currentByte was always 0 which could potentially be a problem in the last call of _processLine() at the end of the method.
https://github.com/mrdoob/three.js/pull/20246/files#diff-0d91ee5a7e6fe5182c3ea5a4f747935eR387
There was a problem hiding this comment.
True, thank you for spotting this.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved some linter issues.