Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Simplify BindGroupLayout creation #20330

Merged
merged 1 commit into from
Sep 13, 2020

Conversation

takahirox
Copy link
Collaborator

This PR simplifies BindGroupLayout Creation.

@Mugen87 Mugen87 merged commit 12d17f2 into mrdoob:dev Sep 13, 2020
@Mugen87 Mugen87 added this to the r121 milestone Sep 13, 2020
@takahirox takahirox deleted the SimplifyBindGroupLayoutCreation branch September 13, 2020 16:42
@Kangz
Copy link

Kangz commented Sep 14, 2020

That works, but note that if you plan to share bind groups between multiple pipelines, you'll have to revert to creating the layout explicitly, otherwise the layouts returned by getBindGroupLayout might not be the same.

@takahirox
Copy link
Collaborator Author

takahirox commented Sep 15, 2020

Thanks for the comment. I think Camera and Light parameters can be shared among objects (pipelines) in a scene. For example, we may create three groups camera (shared), lights (shared), and other pipeline specific parameters (non-shared). If we do that we may need to revert the change, or we may use hybrid (explicit layout creation for shared group while getBindGroupLayout for non-shared). Let's discuss when we optimize in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants