Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object3D: Add note about traversal in docs #20386

Merged
merged 3 commits into from
Sep 27, 2020

Conversation

mjurczyk
Copy link
Contributor

@mjurczyk mjurczyk commented Sep 21, 2020

Based on:
"After deleting the child object, the code cannot be executed" (Removed descendant during traverse)
"Gltf.scene.traverse get TypeError: Cannot read property ‘traverse’ of undefined" (Moved descendant to another parent during traverse)
"Issue with adding and remove items from scene" (Moved descendant to another parent during traverse)
"Add children to a group break traverse method" (Moved descendant to another parent during traverse)
"Super weird behavior with “add()” and looping “scene.children”" (Moved descendant to another parent during traverse)

Adding clarification in the docs could save some confusion, since it is not clear without looking at the code that there's no safe-check on descendant#traverse on this line (edit: we could also just add a safe-check, while we're at it? 🤔 )

@mrdoob
Copy link
Owner

mrdoob commented Sep 22, 2020

Better to use <strong> instead of <b>.

@mrdoob mrdoob added this to the r121 milestone Sep 22, 2020
@mrdoob mrdoob merged commit 9ea590a into mrdoob:dev Sep 27, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 27, 2020

Thanks!

@mjurczyk mjurczyk deleted the object3d-traverse-docs-update branch September 27, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants