Math: Covert to ES6 default value. #20472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Oct 8, 2020
src/math/Matrix4.js
Outdated
| fromArray( array, offset ) { | ||
|
|
||
| if ( offset === undefined ) offset = 0; | ||
| fromArray( array = [], offset = 0 ) { |
There was a problem hiding this comment.
The array parameter should never be optional when using fromArray().
There was a problem hiding this comment.
Thanks for your review, I corrected it.
There was a problem hiding this comment.
@Mugen87 I do not think the array parameter should be optional when using .toArray() either. It is supposed to be populating an existing array, not instantiating one. Instantiating one violates the three.js policy.
Mugen87
approved these changes
Oct 8, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Math: Covert to ES6 default value.