Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Move to let/const. #20484

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Docs: Move to let/const. #20484

merged 1 commit into from
Oct 9, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 9, 2020

Except for Arabic and Chinese translations, this PR moves the documentation to let/const.

@mrdoob mrdoob added this to the r122 milestone Oct 9, 2020
@mrdoob mrdoob merged commit 9476ac3 into mrdoob:dev Oct 9, 2020
@mrdoob
Copy link
Owner

mrdoob commented Oct 9, 2020

Thanks!

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Oct 9, 2020 •
edited

@linbingquan Applying this change to zh would be a great help 😇 . Are you interested?

@Mugen87 Mugen87 mentioned this pull request Oct 9, 2020
Merged
@linbingquan
Copy link
Contributor

@linbingquan Applying this change to zh would be a great help 😇 . Are you interested?

OK, Let me do it. I found several files not just change var to const...

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Oct 9, 2020 •
edited

Yes, you need let at several places otherwise the code won't work. Best to do it file by file (I did it this way).

@linbingquan linbingquan mentioned this pull request Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r122
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mugen87 @mrdoob @linbingquan