-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Add EdgeSplitModifier #20535
Conversation
Thanks for this but I think it's better to not add more modifiers to this repository. It is already large and hard to maintain. I vote to leave such specialized logic in separate repositories and |
I might save this one for later. if we ever open up a 'community-made-features' repo or something similar this would be a cool addition |
I actually like this! |
Where's |
As a consequence I've removed the model from my git repo and switched to using the |
Thanks! |
@Mcgode Do you think it would be possible to build a bevel modifier out of this modifier's code? |
I think there's still a long way to go from my code to implement a bevel modifier. |
About this feature
This geometry modifier allows the user to build an indexed BufferGeometry, where are split on sharp edges. This allows you to compute normals without smoothing the edges :
Without applying the modifier:
After applying the modifier:
Very useful if you're importing a STL file.
How it's implemented
The feature was implemented as an example, using the same structure as the other modifiers.
It also features an example page, which includes a new binary STL model
Additional notes
The feature is also available as a standalone package:
https://github.com/Mcgode/three-js-edge-split-modifier
This contribution is funded by Dioxygen Software for Dualbox.com