Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove obsolete list.js import. #20545

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Docs: Remove obsolete list.js import. #20545

merged 2 commits into from
Oct 22, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 21, 2020

AFAICS, it's sufficient if docs/index.html imports list.js. This is not required for individual pages since page.js does not work with the navigation.

This PR also fixes a minor redirect issue. It ensures that a link like the following is properly processed:

https://threejs.org/docs/manual/en/introduction/Creating-a-scene

Right now, it only works if the link has a html extension

https://threejs.org/docs/manual/en/introduction/Creating-a-scene.html

@mrdoob mrdoob added this to the r122 milestone Oct 22, 2020
@mrdoob mrdoob merged commit 821df03 into mrdoob:dev Oct 22, 2020
@mrdoob
Copy link
Owner

mrdoob commented Oct 22, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants