Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CubeCamera: Moved clear() to WebGLCubeRenderTarget #20565

Merged
merged 3 commits into from
Oct 27, 2020
Merged

CubeCamera: Moved clear() to WebGLCubeRenderTarget #20565

merged 3 commits into from
Oct 27, 2020

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Oct 27, 2020

Related issues:

#20542

Description

I was planning on removing CubeCamera altogether, but seems like moving clear() to WebGLCubeRenderTarget is good enough for now. It makes more sense to have the clear() in WebGLCubeRenderTarget anyway.

@mrdoob mrdoob added this to the r122 milestone Oct 27, 2020
Mugen87
Mugen87 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes more sense to have the clear() in WebGLCubeRenderTarget anyway.

Indeed. Looks good!

@mrdoob mrdoob merged commit ffd9aa7 into dev Oct 27, 2020
@mrdoob mrdoob deleted the cubecamera branch October 27, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r122
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrdoob @Mugen87