Fixes SVGLoader arc parsing with zero radius path commands. #20644
Conversation
|
It's also necessary to update |
examples/jsm/loaders/SVGLoader.js
Outdated
| for ( var j = 0, jl = numbers.length; j < jl; j += 7 ) { | ||
| // skip command if start point == end point | ||
| if( numbers[ j + 5 ] == 0 && numbers[ j + 6 ] == 0 ) continue |
There was a problem hiding this comment.
Shouldn't this line be if( numbers[ j + 5 ] == point.x && numbers[ j + 6 ] == point.y ) continue; ?
There was a problem hiding this comment.
Νο, the 'a' indicates that the arguments are relative to the current point, so a 0 means no displacement
|
Oops, I messed a little bit the review, but the three things are there. |
examples/js/loaders/SVGLoader.js
Outdated
| if( rx == 0 || ry == 0 ) { | ||
| // draw a line if either of the radii == 0 | ||
| path.lineTo( end.x, end.y ); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
As per yomboprime's suggestion
examples/js/loaders/SVGLoader.js
Outdated
|
|
||
| // skip command if start point == end point | ||
| if( numbers[ j + 5 ] == point.x && numbers[ j + 6 ] == point.y ) continue; |
There was a problem hiding this comment.
as per yomboprime's suggestion
|
Minor thing: Can change the |
mrdoob
changed the title
Just committed the changes! |
|
Thanks! |
Related issue: #20641
Description
If an SVG path has an arc command (A/a) with zero radius the path data gets thrown off. Adding a check in the path parser for zero radius fixes this:
Also, to avoid unnecessary computation, a check for useless arc command was added: