Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBJLoader: Better support point clouds. #20724

Merged
merged 2 commits into from
Nov 20, 2020
Merged

OBJLoader: Better support point clouds. #20724

merged 2 commits into from
Nov 20, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 20, 2020

Related issue: -

Description

I've lately encountered an OBJ file that could be loaded in Blender but not by OBJLoader. The file represented a point cloud but without defining a p element. So the file had only lines like:

v -0.050206 1.680299 -0.120761 0.545098 0.345098 0.266667

OBJLoader did already parse this file but the builder logic ignored it because of the missing p element. The PR enhances the loader with an additional if statement that enables the detection of such point cloud data.

@mrdoob mrdoob added this to the r123 milestone Nov 20, 2020
@mrdoob mrdoob merged commit 4dc8173 into mrdoob:dev Nov 20, 2020
@mrdoob
Copy link
Owner

mrdoob commented Nov 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants