OrbitControls: Fixed sticky controls when disabled. #20735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arodic
commented
Nov 22, 2020
| @@ -961,13 +959,13 @@ THREE.OrbitControls = function ( object, domElement ) { | |||
|
|
|||
| function onMouseUp( event ) { | |||
|
|
|||
There was a problem hiding this comment.
Prevents "stickiness" by removing "pointerup" and "pointermove" even if controls are disabled mid-gesture.
arodic
commented
Nov 22, 2020
| @@ -800,8 +800,6 @@ THREE.OrbitControls = function ( object, domElement ) { | |||
|
|
|||
| function onPointerUp( event ) { | |||
|
|
|||
| if ( scope.enabled === false ) return; | |||
There was a problem hiding this comment.
This event is forwarded to onMouseUp that also has the same statement.
|
Seems simpler indeed 👌 |
mrdoob
changed the title
|
Thanks! |
Mugen87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution to #20380
I found this simple fix worked in my case. It does not to anything fancy, only allows pointerUp to to remove pointermove listeners even when the controls are disabled. @gkjohnson