-
-
Notifications
You must be signed in to change notification settings - Fork 35.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLTFExporter: Prepare KHR_mesh_quantization support. #20762
Conversation
Am I correct in understanding that this PR allows some models to be exported with KHR_mesh_quantization, but doesn't fix all of the cases mentioned by #20474 (comment), and so some meshes (that three.js can render, and KHR_mesh_quantization would allow) still won't export? I'm not sure what you mean about making restrictions more visible. The code changes look OK to me — should we be adding the |
No models using
Right now, the exporter throws an error when Functions like |
Sorry if I'm delaying this, the code in this PR looks fine and I have no objection to it, but I cannot tell what this change is supposed to do. If the goal it to support |
This can be revisited after #20842. In this way, a merge of this PR will not produce conflicts. |
I also encountered this error with a particular model. Since #20842 has been merged in the meantime, is there any hope for @donmccurdy can |
@carstenschwede could you clarify what error you are seeing, under what conditions? I don't think there are any known problems with three.js loading a model using If you did need to remove |
@donmccurdy I also only get the error while exporting, i.e. Update: |
Related issue: #20474
Description
This PR makes the current restrictions in the exporter mentioned in #20474 (comment) more visible.