Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAOPass typing fix #20775

Merged
merged 1 commit into from Nov 30, 2020
Merged

SAOPass typing fix #20775

merged 1 commit into from Nov 30, 2020

Conversation

Fluqz
Copy link
Contributor

@Fluqz Fluqz commented Nov 27, 2020

Related issue: Fixed #20769.

Description

Replacing OUTPUT js object with a typescript Enum as type.
Removes the typings error

@mrdoob mrdoob added this to the r124 milestone Nov 30, 2020
@mrdoob mrdoob merged commit f62c3df into mrdoob:dev Nov 30, 2020
@mrdoob
Copy link
Owner

mrdoob commented Nov 30, 2020

Thanks!

@Fluqz Fluqz deleted the saopass-ts branch December 7, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAOPass.OUTPUT is being used as a namespace
3 participants