Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: AxesHelper's examples link update #20785

Merged
merged 4 commits into from Dec 4, 2020

Conversation

gonnavis
Copy link
Contributor

Related issue: -

Description

AxesHelper is currently used in css2d_label, misc_animation_keys, misc_exporter_gltf, webgl_buffergeometry_compression, webgl_geometry_convex, webgl_loader_nrrd examples.

@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 29, 2020

I don't think we have to put all examples where a specific class is used into the Examples listing of the respective doc page. One or two are totally sufficient for a simple classes like AxesHelper.

@gonnavis
Copy link
Contributor Author

webgl_geometries and webgl_geometry_spline_editor don’t use AxesHelper anymore, I mainly to delete these two references.
Should just delete these two without adding other references?

@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 30, 2020

Replacing them sounds fine.

@gonnavis
Copy link
Contributor Author

Does "replacing" mean to keep three examples?
Is it okay to choose these three?
webgl_buffergeometry_compression
webgl_geometry_convex
webgl_loader_nrrd

@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 30, 2020

Is it okay to choose these three?

👍

@gonnavis
Copy link
Contributor Author

Updated.

@Mugen87 Mugen87 added this to the r124 milestone Dec 4, 2020
@Mugen87 Mugen87 merged commit f1c1255 into mrdoob:dev Dec 4, 2020
@mrdoob
Copy link
Owner

mrdoob commented Dec 4, 2020

I don't think we have to put all examples where a specific class is used into the Examples listing of the respective doc page. One or two are totally sufficient for a simple classes like AxesHelper.

Agreed!

@mrdoob
Copy link
Owner

mrdoob commented Dec 4, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants