Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add LightProbe to the object list in ObjectLoader #20988

Merged
merged 1 commit into from
Jan 2, 2021
Merged

Docs: Add LightProbe to the object list in ObjectLoader #20988

merged 1 commit into from
Jan 2, 2021

Conversation

Cloud9c
Copy link
Contributor

@Cloud9c Cloud9c commented Jan 1, 2021 •
edited

Added LightProbe to the list of parse-able objects in the ObjectLoader documentation

@Cloud9c Cloud9c changed the title Add LightProbe to the list of object types Docs: Add LightProbe to the list of object types Jan 1, 2021
@Cloud9c Cloud9c changed the title Docs: Add LightProbe to the list of object types Docs: Add LightProbe to the object list in ObjectLoader Jan 1, 2021
@mrdoob mrdoob added this to the r125 milestone Jan 2, 2021
@mrdoob mrdoob merged commit b3ddccf into mrdoob:dev Jan 2, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 2, 2021

Thanks!

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 2, 2021 •
edited

@mrdoob Listings like in ObjectLoader.parseObject() can easily get out of date and are thus hard to maintain. Next to LightProbe, the classes RectAreaLight, SkinnedMesh and InstancedMesh are also missing.

How about removing it? I mean the listing comes from a time where ObjectLoader did only partly support 3D objects. Right now, all classes from src/objects and all non-experimental lights are supported.

@mrdoob
Copy link
Owner

mrdoob commented Jan 2, 2021

Sounds good to me 👍

@Mugen87 Mugen87 mentioned this pull request Jan 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r125
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Cloud9c @mrdoob @Mugen87