Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRACOExporter: Stop support for Geometry. #21008

Merged
merged 1 commit into from
Jan 5, 2021
Merged

DRACOExporter: Stop support for Geometry. #21008

merged 1 commit into from
Jan 5, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 5, 2021 •
edited

Related issue: -

Description

This PR ensures DRACOExporter does not support Geometry anymore. If users want to use the exporter with Geometry, they have to perform the conversion to BufferGeometry by themselves.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 5, 2021

@mrdoob If your are okay with this change, I suggest to remove THREE.Geometry support from all exporters.

@mrdoob
Copy link
Owner

mrdoob commented Jan 5, 2021 •
edited

Sounds good to me! 👍

@mrdoob mrdoob added this to the r125 milestone Jan 5, 2021
@mrdoob mrdoob merged commit 68fff66 into mrdoob:dev Jan 5, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 5, 2021

Thanks!

@Mugen87 Mugen87 mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r125
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mugen87 @mrdoob