Object3D.toJSON : Add demo implementation to retain typed buffers in result #21035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #11746 (comment)
Description
As requested in #11746 (comment) here's a quick PR demonstrating what has to change in order for
Object3D.toJSON
to retain BufferGeometry typed arrays when serializing and for ObjectLoader to reuse the buffers when deserializing. A second argument has been added toObject3D.toJSON( meta, cloneTransferableTypes )
to give the option for transferable types to not be cloned and instead be returned by reference. The default setting defaults to true which means the behavior is unchanged from three.js master.As mentioned in #11746 (comment) removing the conversion of arrays in
toJSON
andObjectLoader
greatly improves the performance in both cases and would make it viable for users to load and perform longer running processes on geometry in web workers because the serialization, deserialization, and transfer time to the main thread is much faster.Here are some possible next steps for a full implementation which can be done in steps:
Texture
andObjectLoader
to return a reference to and directly useImageBitmap