KeyframeTrack: Fix typo in optimize(). #21071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
changed the title
Mugen87
approved these changes
Jan 12, 2021
Mugen87
changed the title
|
Thanks! |
Not sure anyone is looking at that code much... |
|
Ops, this targeted |
|
Ah sorry about that! Used the github UI and forgot to change the branch dropdown. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes what appears to be a typo in
track.optimize(). I haven't run into a reproducible issue but accessingtime[0]wheretimeis a number does not seem correct.Aside: The
optimize()function currently only eliminates duplicate keyframes. Have we considered changing the implementation to remove keyframes that can be linearly interpolated from the prev/next keyframes? I think that could remove a lot more from animations that were 'baked' in software like Blender.